Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753798Ab3HBBfo (ORCPT ); Thu, 1 Aug 2013 21:35:44 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:53960 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752890Ab3HBBfm (ORCPT ); Thu, 1 Aug 2013 21:35:42 -0400 X-IronPort-AV: E=Sophos;i="4.89,797,1367942400"; d="scan'208";a="8093323" Message-ID: <51FB0C95.8040207@cn.fujitsu.com> Date: Fri, 02 Aug 2013 09:34:13 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Toshi Kani CC: rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 04/18] acpi: Introduce acpi_invalid_table() to check if a table is invalid. References: <1375340800-19332-1-git-send-email-tangchen@cn.fujitsu.com> <1375340800-19332-5-git-send-email-tangchen@cn.fujitsu.com> <1375396019.10300.32.camel@misato.fc.hp.com> In-Reply-To: <1375396019.10300.32.camel@misato.fc.hp.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/02 09:34:23, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/02 09:34:25, Serialize complete at 2013/08/02 09:34:25 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 24 On 08/02/2013 06:26 AM, Toshi Kani wrote: ...... >> +int __init acpi_invalid_table(struct cpio_data *file, >> + const char *path, const char *signature) > > Since this function verifies a given acpi table in initrd (not that the > table is invalid), I'd suggest to rename it something like > acpi_verify_initrd(). Otherwise, it looks good to me. > Hi Toshi-san, Thanks, will change the name. Thanks. > Acked-by: Toshi Kani > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/