Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501Ab3HBE3T (ORCPT ); Fri, 2 Aug 2013 00:29:19 -0400 Received: from mga03.intel.com ([143.182.124.21]:33420 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853Ab3HBE3S (ORCPT ); Fri, 2 Aug 2013 00:29:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,798,1367996400"; d="scan'208";a="276615526" Message-ID: <51FB35CD.7040709@intel.com> Date: Fri, 02 Aug 2013 12:30:05 +0800 From: Aaron Lu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Felipe Contreras CC: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Zhang Rui Subject: Re: [PATCH] acpi: video: fix reversed indexed BQC References: <1375400042-989-1-git-send-email-felipe.contreras@gmail.com> <51FB137D.7070000@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 33 On 08/02/2013 12:11 PM, Felipe Contreras wrote: > On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote: >> On 08/02/2013 07:34 AM, Felipe Contreras wrote: >>> Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use >>> index values) assumed that bl->levels were not reverted, but at this >>> point they already are, so there's no need to revert them yet again. >> >> When acpi_video_bqc_value_to_level is called, bl->levels is not >> reverted. > > This is the code that turns br->flags._BCL_reversed on: > > if (max_level == br->levels[2]) { > br->flags._BCL_reversed = 1; > sort(&br->levels[2], count - 2, sizeof(br->levels[2]), > acpi_video_cmp_level, NULL); > } > > Now tell me how br->flags._BCL_reversed can be on, and the br->levels > *not* reverted. Oh yes, it is reverted to be in increase order, so it is not in reverse order. I'm a little confused by these words. Please see acpi_video_bqc_quirk, we set _BQC_use_index by revert the level on a reversed _BCL, so we will need to revert level here too. -Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/