Message-ID: <1375444203.4098.11.camel@pizza.hi.pengutronix.de>
Subject: Re: [PATCH v3 6/6] mfd: da9063: add 32 kHz output clock to clock
 tree
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Date: Fri, 02 Aug 2013 13:50:03 +0200
In-Reply-To: <20130729181554.GB9858@sirena.org.uk>
References: <1375117247-6376-1-git-send-email-p.zabel@pengutronix.de>
	 <1375117247-6376-7-git-send-email-p.zabel@pengutronix.de>
	 <20130729181554.GB9858@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 971
Lines: 26

Am Montag, den 29.07.2013, 19:15 +0100 schrieb Mark Brown:
> On Mon, Jul 29, 2013 at 07:00:47PM +0200, Philipp Zabel wrote:
> 
> > +	clk = devm_clk_register(da9063->dev, &out_32k->clk_hw);
> > +	if (IS_ERR(clk))
> > +		return PTR_ERR(clk);
> > +
> 
> This introduces a dependency on COMMON_CLK.  It might be best to make
> this a function device in drivers/clk, and for something like this we
> really ought to be able to create regmap helpers though that can be done
> later on.

If we just add regmap variants of the current basic clocks (think
clk_gate_regmap etc.) there wouldn't be much code left for this function
device. I'll drop the clock part for now and reintroduce it after we
have some helpers.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/