Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753407Ab3HBOk0 (ORCPT ); Fri, 2 Aug 2013 10:40:26 -0400 Received: from zetta.elopez.com.ar ([199.30.59.35]:57278 "EHLO zetta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752556Ab3HBOkY (ORCPT ); Fri, 2 Aug 2013 10:40:24 -0400 Message-ID: <51FBC4CE.8090009@elopez.com.ar> Date: Fri, 02 Aug 2013 11:40:14 -0300 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Maxime Ripard CC: Mike Turquette , kevin.z.m.zh@gmail.com, sunny@allwinnertech.com, shuge@allwinnertech.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: sun5i: dt: Use the A10s gates in the DTSI References: <1374618504-19391-1-git-send-email-maxime.ripard@free-electrons.com> <1374618504-19391-3-git-send-email-maxime.ripard@free-electrons.com> In-Reply-To: <1374618504-19391-3-git-send-email-maxime.ripard@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3723 Lines: 105 Hi Maxime, El 23/07/13 19:28, Maxime Ripard escribi?: > The A10s has only a subset of the A10 gates. Now that the clock driver > has support for this gates set, switch to it in the DTSI. > > Signed-off-by: Maxime Ripard As I mentioned on the other patch, my board boots, so Tested-by: Emilio L?pez > --- > arch/arm/boot/dts/sun5i-a10s.dtsi | 36 ++++++++++++++---------------------- > 1 file changed, 14 insertions(+), 22 deletions(-) > > diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5i-a10s.dtsi > index 0f0881a..b8fc1c2 100644 > --- a/arch/arm/boot/dts/sun5i-a10s.dtsi > +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi > @@ -95,20 +95,16 @@ > > ahb_gates: ahb_gates@01c20060 { > #clock-cells = <1>; > - compatible = "allwinner,sun4i-ahb-gates-clk"; > + compatible = "allwinner,sun5i-a10s-ahb-gates-clk"; > reg = <0x01c20060 0x8>; > clocks = <&ahb>; > - clock-output-names = "ahb_usb0", "ahb_ehci0", > - "ahb_ohci0", "ahb_ehci1", "ahb_ohci1", "ahb_ss", > - "ahb_dma", "ahb_bist", "ahb_mmc0", "ahb_mmc1", > - "ahb_mmc2", "ahb_mmc3", "ahb_ms", "ahb_nand", > - "ahb_sdram", "ahb_ace", "ahb_emac", "ahb_ts", > - "ahb_spi0", "ahb_spi1", "ahb_spi2", "ahb_spi3", > - "ahb_pata", "ahb_sata", "ahb_gps", "ahb_ve", > - "ahb_tvd", "ahb_tve0", "ahb_tve1", "ahb_lcd0", > - "ahb_lcd1", "ahb_csi0", "ahb_csi1", "ahb_hdmi", > - "ahb_de_be0", "ahb_de_be1", "ahb_de_fe0", > - "ahb_de_fe1", "ahb_mp", "ahb_mali400"; > + clock-output-names = "ahb_usbotg", "ahb_ehci", "ahb_ohci", > + "ahb_ss", "ahb_dma", "ahb_bist", "ahb_mmc0", > + "ahb_mmc1", "ahb_mmc2", I noticed the vendor code also has "ahb_ms" here, it might be worth keeping it in mind. > "ahb_nand", "ahb_sdram", > + "ahb_emac", "ahb_ts", "ahb_spi0", "ahb_spi1", > + "ahb_spi2", "ahb_gps", "ahb_stimer", "ahb_ve", > + "ahb_tve", "ahb_lcd", "ahb_csi", "ahb_hdmi", > + "ahb_de_be", "ahb_de_fe", "ahb_iep", "ahb_mali400"; > }; > > apb0: apb0@01c20054 { > @@ -120,12 +116,11 @@ > > apb0_gates: apb0_gates@01c20068 { > #clock-cells = <1>; > - compatible = "allwinner,sun4i-apb0-gates-clk"; > + compatible = "allwinner,sun5i-a10s-apb0-gates-clk"; > reg = <0x01c20068 0x4>; > clocks = <&apb0>; > - clock-output-names = "apb0_codec", "apb0_spdif", > - "apb0_ac97", "apb0_iis", "apb0_pio", "apb0_ir0", > - "apb0_ir1", "apb0_keypad"; > + clock-output-names = "apb0_codec", "apb0_iis", "apb0_pio", > + "apb0_ir", "apb0_keypad"; > }; > > /* dummy is pll62 */ > @@ -145,15 +140,12 @@ > > apb1_gates: apb1_gates@01c2006c { > #clock-cells = <1>; > - compatible = "allwinner,sun4i-apb1-gates-clk"; > + compatible = "allwinner,sun5i-a10s-apb1-gates-clk"; > reg = <0x01c2006c 0x4>; > clocks = <&apb1>; > clock-output-names = "apb1_i2c0", "apb1_i2c1", > - "apb1_i2c2", "apb1_can", "apb1_scr", > - "apb1_ps20", "apb1_ps21", "apb1_uart0", > - "apb1_uart1", "apb1_uart2", "apb1_uart3", > - "apb1_uart4", "apb1_uart5", "apb1_uart6", > - "apb1_uart7"; > + "apb1_i2c2", "apb1_uart0", "apb1_uart1", > + "apb1_uart2", "apb1_uart3"; > }; > }; > > An update to the documentation mentioning these compatibles[1] and gates[2] would be great :) [1] Documentation/devicetree/bindings/clock/sunxi.txt [2] Documentation/devicetree/bindings/clock/sunxi/sun5i-a10s-gates.txt Thanks for working on this! Emilio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/