Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754958Ab3HBRSS (ORCPT ); Fri, 2 Aug 2013 13:18:18 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:22963 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754670Ab3HBRSP (ORCPT ); Fri, 2 Aug 2013 13:18:15 -0400 X-IronPort-AV: E=Sophos;i="4.89,802,1367971200"; d="scan'208";a="39093382" Date: Fri, 2 Aug 2013 18:18:00 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Julien Grall CC: , , , , , Subject: Re: [PATCH] xen/arm: missing put_cpu in xen_percpu_init In-Reply-To: <1375113966-2859-1-git-send-email-julien.grall@linaro.org> Message-ID: References: <1375113966-2859-1-git-send-email-julien.grall@linaro.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 38 On Mon, 29 Jul 2013, Julien Grall wrote: > When CONFIG_PREEMPT is enabled, Linux will not be able to boot and warn: > [ 4.127825] ------------[ cut here ]------------ > [ 4.133376] WARNING: at init/main.c:699 do_one_initcall+0x150/0x158() > [ 4.140738] initcall xen_init_events+0x0/0x10c returned with preemption imbalance > > This is because xen_percpu_init uses get_cpu but doesn't have the corresponding > put_cpu. > > Signed-off-by: Julien Grall Ops. Thanks for catching the bug. I'll add this to my queue. > arch/arm/xen/enlighten.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index f71c37e..dc9f284 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -170,6 +170,7 @@ static void __init xen_percpu_init(void *unused) > per_cpu(xen_vcpu, cpu) = vcpup; > > enable_percpu_irq(xen_events_irq, 0); > + put_cpu(); > } > > static void xen_restart(char str, const char *cmd) > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/