Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893Ab3HBRtz (ORCPT ); Fri, 2 Aug 2013 13:49:55 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:34171 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627Ab3HBRty convert rfc822-to-8bit (ORCPT ); Fri, 2 Aug 2013 13:49:54 -0400 From: Dan Williams To: Andy Shevchenko CC: Vinod Koul , Linux Kernel Mailing List , Dave Jiang , "Blin, Jerome" , Viresh Kumar , "rostedt@goodmis.org" Subject: Re: [PATCH 1/3] dmatest: make module parameters writable Thread-Topic: [PATCH 1/3] dmatest: make module parameters writable Thread-Index: AQHOh7p6sYhbiZEqiE253lzrXOCaM5l/WkAAgALnlYA= Date: Fri, 2 Aug 2013 17:49:32 +0000 Message-ID: In-Reply-To: <1375280890.31118.69.camel@smile> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [192.168.16.4] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794,1.0.431,0.0.0000 definitions=2013-08-02_06:2013-08-02,2013-08-02,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1515 Lines: 46 On 7/31/13 7:28 AM, "Andy Shevchenko" wrote: >On Tue, 2013-07-23 at 18:36 +0300, Andy Shevchenko wrote: >> The debugfs interface brought a copy of the test case parameters. This >>makes >> different set of values under /sys/module/dmatest/parameters/ and >> /sys/kernel/debug/dmatest/. The user might be confused by the >>divergence of >> values. >> >> The proposed solution in this patch is to make module parameters >>writable and >> remove them from the debugfs. Though we're still using debugfs to >>control test >> runner and getting results. >> >> Documentation part is updated accordingly. >> >> Signed-off-by: Andy Shevchenko >> Suggested-by: Dan Williams > >Dan, do you have any comments against this series? >I'd like to have this incorporated into v3.12. I like this direction, and these can go in as is. But I think with a bit more work we can eventually trim the ?results' file and the thread_{add|get}_result infrastructure. Ideally we could move all result reporting to ftrace and let a module parameter control which errors are reported. However, unless I missed it, I don?t see this support[1] upstream yet. -- Dan [1]: https://lwn.net/Articles/432186/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/