Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754594Ab3HBR4N (ORCPT ); Fri, 2 Aug 2013 13:56:13 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:33316 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753161Ab3HBR4L convert rfc822-to-8bit (ORCPT ); Fri, 2 Aug 2013 13:56:11 -0400 MIME-Version: 1.0 In-Reply-To: <2112254.EC1eeAtOxW@vostro.rjw.lan> References: <1375400641-1694-1-git-send-email-felipe.contreras@gmail.com> <51FB118D.8040205@gmail.com> <2112254.EC1eeAtOxW@vostro.rjw.lan> Date: Fri, 2 Aug 2013 12:56:09 -0500 Message-ID: Subject: Re: [PATCH 2/3] acpi: video: trivial style cleanups From: Felipe Contreras To: "Rafael J. Wysocki" Cc: Aaron Lu , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , Zhang Rui , Jiri Kosina Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 39 On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki wrote: > On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote: >> On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu wrote: >> > On 08/02/2013 07:44 AM, Felipe Contreras wrote: >> >> Signed-off-by: Felipe Contreras >> > >> > Change log please. >> >> You mean a commit message? > > No. He meant the part that goes between the subject and the signoff. > This is called a change log (or changelog). Not in Git lingo. % man git commit "Though not required, it’s a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description." >> That's what it's called in Git lingo, and >> it's right there: >> >> acpi: video: trivial style cleanups > > And that's not sufficient, because it doesn't explain *what* cleanups are > being made. Yes it does; *style* cleanups (coding-style). -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/