Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548Ab3HBULY (ORCPT ); Fri, 2 Aug 2013 16:11:24 -0400 Received: from smtp65.ord1c.emailsrvr.com ([108.166.43.65]:57357 "EHLO smtp65.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218Ab3HBULV (ORCPT ); Fri, 2 Aug 2013 16:11:21 -0400 Message-ID: <51FC1272.8010305@calxeda.com> Date: Fri, 02 Aug 2013 15:11:30 -0500 From: Mark Langsdorf User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergei Shtylyov CC: "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "tj@kernel.org" , "devicetree@vger.kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "swarren@wwwdotorg.org" , "ian.campbell@citrix.com" , Rob Herring Subject: Re: [PATCH v2 3/5] devicetree: create a separate binding description for sata_highbank References: <1375460918-4661-1-git-send-email-mark.langsdorf@calxeda.com> <1375460918-4661-3-git-send-email-mark.langsdorf@calxeda.com> <51FC1015.7010203@cogentembedded.com> In-Reply-To: <51FC1015.7010203@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3545 Lines: 93 On 08/02/2013 03:01 PM, Sergei Shtylyov wrote: > On 08/02/2013 08:28 PM, Mark Langsdorf wrote: > >> The Calxeda sata_highbank driver has been adding its descriptions to the >> ahci driver. Separate them properly. > >> Signed-off-by: Mark Langsdorf >> Acked-by: Rob Herring > [...] > >> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt >> index 3ec0c5c..14d7b22 100644 >> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt >> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt >> @@ -4,27 +4,17 @@ SATA nodes are defined to describe on-chip Serial ATA controllers. > [...] >> Example: >> sata@ffe08000 { >> - compatible = "calxeda,hb-ahci"; >> + compatible = "snps,spear-ahci"; >> reg = <0xffe08000 0x1000>; >> interrupts = <115>; > > Indented these 2 props with spaces, would be good to fix... Thanks, I will fix. >> - calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 >> - &combophy0 2 &combophy0 3>; >> >> }; >> diff --git a/Documentation/devicetree/bindings/ata/sata_highbank.txt b/Documentation/devicetree/bindings/ata/sata_highbank.txt >> new file mode 100644 >> index 0000000..aa1b798 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/sata_highbank.txt > Shouldn't the file be called calxeda,hb-ahci.txt? # ls Documentation/devicetree/bindings/ata/ ahci-platform.txt exynos-sata.txt pata-arasan.txt atmel-at91_cf.txt fsl-sata.txt sata_highbank.txt cavium-compact-flash.txt imx-pata.txt exynos-sata-phy.txt marvell.txt By comparison with the other files in the directory, no. Using _ instead of - is slightly unorthodox but not unknown within the devicetree/bindings subdirectories. >> @@ -0,0 +1,32 @@ >> +* Calxeda AHCI SATA Controller >> + >> +SATA nodes are defined to describe on-chip Serial ATA controllers. >> +The Calxeda SATA controller mostly conforms to the AHCI interface >> +with some special extensions to add functionality. >> +Each SATA controller should have its own node. >> + >> +Required properties: >> +- compatible : compatible list, contains "calxeda,hb-ahci" >> +- interrupts : >> +- reg : >> + >> +Optional properties: >> +- dma-coherent : Present if dma operations are coherent >> +- calxeda,port-phys: phandle-combophy and lane assignment, which maps each >> + SATA port to a combophy and a lane within that >> + combophy >> +- calxeda,sgpio-gpio: phandle-gpio bank, bit offset, and default on or off, >> + which indicates that the driver supports SGPIO >> + indicator lights using the indicated GPIOs >> +- calxeda,led-order : a u32 array that map port numbers to offsets within the >> + SGPIO bitstream. >> + >> +Example: >> + sata@ffe08000 { >> + compatible = "calxeda,hb-ahci"; >> + reg = <0xffe08000 0x1000>; >> + interrupts = <115>; >> + calxeda,port-phys = <&combophy5 0 &combophy0 0 &combophy0 1 > > Could you indent props uniformly here, with tabs? Yes. Thanks for the review. --Mark Langsdorf Calxeda, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/