Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240Ab3HBX5R (ORCPT ); Fri, 2 Aug 2013 19:57:17 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:52805 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753950Ab3HBX5P (ORCPT ); Fri, 2 Aug 2013 19:57:15 -0400 From: "Rafael J. Wysocki" To: Felipe Contreras Cc: Aaron Lu , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , Zhang Rui , Jiri Kosina Subject: Re: [PATCH 1/3] acpi: video: trivial costmetic cleanups Date: Sat, 03 Aug 2013 02:07:28 +0200 Message-ID: <2947185.O65YUjZvxL@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <1375400641-1694-1-git-send-email-felipe.contreras@gmail.com> <2368382.8sxrvVTxSB@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 44 On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki wrote: > > On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote: > >> On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu wrote: > >> > On 08/02/2013 07:43 AM, Felipe Contreras wrote: > >> >> Signed-off-by: Felipe Contreras > >> > > >> > Please add change log explaining what you have changed. > >> > It seems that the patch modify comment style only, some add a space and > >> > some change spaces to tab, is it the case? > >> > >> The commit message already explains what the change is; trivial > >> cosmetic cleanups. Cosmetic means it's completely superficial. > > > > And I have a rule not to apply patches without changelogs. So either I'll > > need to write it for you, or can you add one pretty please? > > The commit message is right there. Maybe Jiri can apply it then, if > not, then stay happy with your untidy code. First of all, I didn't say I wouldn't apply the patch, did I? Second, I asked you *nicely* to add a changelog so that I don't need to write it for you. I don't know what made it difficult to understand. Anyway, I ask everyone to write changelogs and nobody has had any problems with that so far. I don't see why I should avoid asking you to follow the rules that everybody else is asked to follow. If those rules are too difficult for you to follow, I'm sorry. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/