Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751329Ab3HCHYj (ORCPT ); Sat, 3 Aug 2013 03:24:39 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:54471 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221Ab3HCHYh (ORCPT ); Sat, 3 Aug 2013 03:24:37 -0400 Message-ID: <51FCAFFB.4000005@ahsoftware.de> Date: Sat, 03 Aug 2013 09:23:39 +0200 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130712 Thunderbird/17.0.7 MIME-Version: 1.0 To: Javier Martinez Canillas CC: Linus Walleij , Grant Likely , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Linux-OMAP , "devicetree@vger.kernel.org" , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Santosh Shilimkar , Kevin Hilman , Balaji T K , Tony Lindgren , Jon Hunter Subject: Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs References: <1375101368-17645-1-git-send-email-linus.walleij@linaro.org> <51F8CC35.1070704@collabora.co.uk> <51FB8292.9090000@ahsoftware.de> <51FBD1CA.1000202@ahsoftware.de> In-Reply-To: <51FBD1CA.1000202@ahsoftware.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 35 Am 02.08.2013 17:35, schrieb Alexander Holler: > Am 02.08.2013 11:57, schrieb Alexander Holler: > >> There must have been a bug in the patch too. I've also added that >> iinterrupt-parent stuff (with the same flags as used by the driver) and >> just have let the driver call >> >> request_threaded_irq(gpio_to_irq(gpio), flags); >> >> without the gpio_request()/input() before. And request_threaded_irq() Thinking again about what I've tried, I might have make the failure to add the interrupt-parent line to the mmc-section (where the gpio was specified) and not to the gpio(-controller) section where it might have belong too (again, there was no example and no documentation). But why I again bother you all with another mail, is that I don't like the fact that the irq-flags might have to be specified in the DT and the source (and they have to match). A solution might be to use the flags specified in the DT for the particular irq and ignore the flags specified as parameter to request_irq(). At least as long as DT isn't mandatory. And in the future, the flags could just be removed from the call to request_irq() depending (then visible too) only on the flags as specified in the DT. Regards, Alexander Holler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/