Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462Ab3HCQZx (ORCPT ); Sat, 3 Aug 2013 12:25:53 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:51010 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194Ab3HCQZu convert rfc822-to-8bit (ORCPT ); Sat, 3 Aug 2013 12:25:50 -0400 Date: Sat, 3 Aug 2013 18:26:36 +0200 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc Message-ID: <20130803182636.012cccb2@armhf> In-Reply-To: <20130803134855.GZ23006@n2100.arm.linux.org.uk> References: <20130731081858.53413597@armhf> <20130803134855.GZ23006@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; arm-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 42 On Sat, 3 Aug 2013 14:48:55 +0100 Russell King - ARM Linux wrote: > On Wed, Jul 31, 2013 at 08:18:58AM +0200, Jean-Francois Moine wrote: > > diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c > > index 9844010..4f817a2 100644 > > --- a/sound/soc/kirkwood/kirkwood-i2s.c > > +++ b/sound/soc/kirkwood/kirkwood-i2s.c > > @@ -25,7 +25,7 @@ > > > > #include "kirkwood.h" > > > > -#define DRV_NAME "kirkwood-i2s" > > +#define DRV_NAME "mvebu-pcm-audio" > > This breaks non-DT users of this driver. The device in arch/arm/mach-kirkwood > is left as "kirkwood-i2s" but the platform device is now called something > different. Oops, sorry, the patch to arch/arm/mach-kirkwood/common.c went away when I pulled the last kernel. > > static struct of_device_id kirkwood_i2s_of_match[] = { > > - { .compatible = "marvell,kirkwood-i2s" }, > > + { .compatible = "marvell,mvebu-pcm-audio" }, > > You've only just introduced "marvell,kirkwood-i2s" in the previous patch. > Why introduce something and then immediately change its name? This makes > no sense what so ever. 2 patches for 2 different purposes. The first one just adds the DT support. It is enough for DT based kernels. But some people wanted the device name to be changed to 'mvebu'. So, the second patch. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/