Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753794Ab3HDTlV (ORCPT ); Sun, 4 Aug 2013 15:41:21 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:34156 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753423Ab3HDTlT (ORCPT ); Sun, 4 Aug 2013 15:41:19 -0400 Date: Sun, 4 Aug 2013 20:40:53 +0100 From: Mark Brown To: Jean-Francois Moine Cc: Russell King - ARM Linux , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Message-ID: <20130804194053.GV9858@sirena.org.uk> References: <20130731081858.53413597@armhf> <20130803134855.GZ23006@n2100.arm.linux.org.uk> <20130803182636.012cccb2@armhf> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="isYHVKADKR45LecX" Content-Disposition: inline In-Reply-To: <20130803182636.012cccb2@armhf> X-Cookie: You will be awarded some great honor. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 94.175.92.69 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2191 Lines: 54 --isYHVKADKR45LecX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 03, 2013 at 06:26:36PM +0200, Jean-Francois Moine wrote: > Russell King - ARM Linux wrote: > > > static struct of_device_id kirkwood_i2s_of_match[] =3D { > > > - { .compatible =3D "marvell,kirkwood-i2s" }, > > > + { .compatible =3D "marvell,mvebu-pcm-audio" }, =20 > > You've only just introduced "marvell,kirkwood-i2s" in the previous patc= h. > > Why introduce something and then immediately change its name? This mak= es > > no sense what so ever. > 2 patches for 2 different purposes. The first one just adds the DT > support. It is enough for DT based kernels. But some people wanted the > device name to be changed to 'mvebu'. So, the second patch. There is no need for the DT name to be connected to the Linux internal platform device name, just use the final name to start with. --isYHVKADKR45LecX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR/q5CAAoJELSic+t+oim92rYP/A9m6JvaQfFjiPOE8C/mZLxv yIu9Nzg8IEs2+HLgSVYYEQtf3Z/wBHyk69UGuWfWYLmJ9lGaDznQ6SKgPk4sq3zY BixiFv2U1Gt1A6kwSJ3SyhHU+kpEwIqCWQtfw25Q7jKzaoFrB71yfYNU2lN2htEl 8xd+pWSPu9xqQSg24fgq9mRyqA8+CTc2PJUSz+/99FdOL3cFgGLR41v9ZUxmZGmC Fw//SxrIetx3R/iKHpCK6lxeDoqYyS4NvOWI+Hn2xHMvDLC/19R+PQfULlU6gb4X bJBU1vXkXjXtrBEdNPLy42SoGl5glLIzzAG34bUu9M1g4LcMKHqp2FLgXlnw6gyM EsU+6iQGtpBa46McVOyCuVwEFbb6zF8xsHnPGTe0R0VyhU2mValfMLz1Ab515rOg SDnQiLwOvuBh64IWofsyiyVhA/iJ4mU1iFGW7YO3bGznMC8w+2TBAYyXchF7U52W x/3AL9BmcJvrC1OUDo88HLu2GRHhiBIb2aF9V3rJTxyJVNVo+Uh8bL0KUep5zdrh mLLKqP6ji3CSh6IlnboEeze8jFxZNNBcvXRkO1lE8DOBkrzpZJ6M3tNcgNtRGFBg iox2x698YVD75q3BB0HStBoqJD9nb/5xpnOxfLbsYq5GVbP1a7ho50fsWyLjgjiA JCrt3nM8ieAkNv4l1c99 =NnIB -----END PGP SIGNATURE----- --isYHVKADKR45LecX-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/