Date: Sun, 04 Aug 2013 18:51:46 -0700 (PDT)
Message-Id: <20130804.185146.1621476659301936865.davem@davemloft.net>
To: hpa@zytor.com
Cc: dh.herrmann@gmail.com, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com,
        tomi.valkeinen@ti.com, santiago@crfreenet.org
Subject: Re: [PATCH] fbdev: suppress warning when assigning
 vga-save/restore base
From: David Miller <davem@davemloft.net>
In-Reply-To: <51FE907A.2090201@zytor.com>
References: <1375637141-2878-1-git-send-email-dh.herrmann@gmail.com>
	<51FE907A.2090201@zytor.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 820
Lines: 21

From: "H. Peter Anvin" <hpa@zytor.com>
Date: Sun, 04 Aug 2013 10:33:46 -0700

> Anyone who can dig backwards and summarize?  In other words:
> 
> Where in the current code do we stuff a physical address in a pointer,
> or a virtual address into a non-pointer?

The VGA register accessors try to accomodate iomem and ioport
accesses.

If they are given a non-NULL iomem pointer 'regbase' they use
iomem accesses, otherwise they do direct ISA port poking.

And yes the drivers in question are making some brash assumptions.
I suspect they should be using ioremap() or similar.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/