Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636Ab3HEGAF (ORCPT ); Mon, 5 Aug 2013 02:00:05 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:44237 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754318Ab3HEGAD (ORCPT ); Mon, 5 Aug 2013 02:00:03 -0400 Message-ID: <51FF3F5F.7030706@hitachi.com> Date: Mon, 05 Aug 2013 14:59:59 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim Cc: Steven Rostedt , Namhyung Kim , Hyeoncheol Lee , LKML , Srikar Dronamraju , Oleg Nesterov , "zhangwei(Jovi)" , Arnaldo Carvalho de Melo Subject: Re: [PATCH 09/13] tracing/uprobes: Fix a comment for uprobe registration syntax References: <1375261410-11219-1-git-send-email-namhyung@kernel.org> <1375261410-11219-10-git-send-email-namhyung@kernel.org> In-Reply-To: <1375261410-11219-10-git-send-email-namhyung@kernel.org> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 48 (2013/07/31 18:03), Namhyung Kim wrote: > From: Namhyung Kim > > The uprobe syntax requires an offset after a file path not a symbol. Is this a bugfix? If so, IMHO, it should be applied earlier in the series. Reviewed-by: Masami Hiramatsu > > Cc: Masami Hiramatsu > Cc: Srikar Dronamraju > Cc: Oleg Nesterov > Cc: zhangwei(Jovi) > Cc: Arnaldo Carvalho de Melo > Signed-off-by: Namhyung Kim > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index f78098398a61..2888b95b063f 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -196,7 +196,7 @@ end: > > /* > * Argument syntax: > - * - Add uprobe: p|r[:[GRP/]EVENT] PATH:SYMBOL [FETCHARGS] > + * - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] > * > * - Remove uprobe: -:[GRP/]EVENT > */ > -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/