Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754337Ab3HEGWP (ORCPT ); Mon, 5 Aug 2013 02:22:15 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:37647 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670Ab3HEGWO (ORCPT ); Mon, 5 Aug 2013 02:22:14 -0400 Message-ID: <51FF4492.8080100@hitachi.com> Date: Mon, 05 Aug 2013 15:22:10 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim Cc: Steven Rostedt , Namhyung Kim , Hyeoncheol Lee , LKML , Srikar Dronamraju , Oleg Nesterov , "zhangwei(Jovi)" , Arnaldo Carvalho de Melo Subject: Re: [PATCH 13/13] tracing/probes: Fix basic print type functions References: <1375261410-11219-1-git-send-email-namhyung@kernel.org> <1375261410-11219-14-git-send-email-namhyung@kernel.org> In-Reply-To: <1375261410-11219-14-git-send-email-namhyung@kernel.org> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2825 Lines: 73 (2013/07/31 18:03), Namhyung Kim wrote: > From: Namhyung Kim > > The print format of s32 type was "ld" and it's casted to "long". So > it turned out to print 4294967295 for "-1" on 64-bit systems. Not > sure whether it worked well on 32-bit systems. > > Anyway, it'd be better if we have exact format and type cast for each > types on both of 32- and 64-bit systems. In fact, the only difference > is on s64/u64 types. Thank you for fixing this :) But, again, this should be at the first place on the series, so that we can push this to stable tree too. Thanks, > > Cc: Masami Hiramatsu > Cc: Srikar Dronamraju > Cc: Oleg Nesterov > Cc: zhangwei(Jovi) > Cc: Arnaldo Carvalho de Melo > Signed-off-by: Namhyung Kim > --- > kernel/trace/trace_probe.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index 8ad48ca4e344..e84e6134f1fb 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -45,14 +45,19 @@ __kprobes int PRINT_TYPE_FUNC_NAME(type)(struct trace_seq *s, \ > } \ > const char PRINT_TYPE_FMT_NAME(type)[] = fmt; > > -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, "%x", unsigned int) > -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned int) > -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, "%lx", unsigned long) > +DEFINE_BASIC_PRINT_TYPE_FUNC(u8 , "%x", unsigned char) > +DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned short) > +DEFINE_BASIC_PRINT_TYPE_FUNC(u32, "%x", unsigned int) > +DEFINE_BASIC_PRINT_TYPE_FUNC(s8, "%d", signed char) > +DEFINE_BASIC_PRINT_TYPE_FUNC(s16, "%d", short) > +DEFINE_BASIC_PRINT_TYPE_FUNC(s32, "%d", int) > +#if BITS_PER_LONG == 32 > DEFINE_BASIC_PRINT_TYPE_FUNC(u64, "%llx", unsigned long long) > -DEFINE_BASIC_PRINT_TYPE_FUNC(s8, "%d", int) > -DEFINE_BASIC_PRINT_TYPE_FUNC(s16, "%d", int) > -DEFINE_BASIC_PRINT_TYPE_FUNC(s32, "%ld", long) > DEFINE_BASIC_PRINT_TYPE_FUNC(s64, "%lld", long long) > +#else /* BITS_PER_LONG == 64 */ > +DEFINE_BASIC_PRINT_TYPE_FUNC(u64, "%lx", unsigned long) > +DEFINE_BASIC_PRINT_TYPE_FUNC(s64, "%ld", long) > +#endif > > /* Print type function for string type */ > __kprobes int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, > -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/