Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593Ab3HEGb7 (ORCPT ); Mon, 5 Aug 2013 02:31:59 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:36186 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752566Ab3HEGb6 (ORCPT ); Mon, 5 Aug 2013 02:31:58 -0400 Message-ID: <1375684317.3133.25.camel@joe-AO722> Subject: Re: [PATCH 13/13] tracing/probes: Fix basic print type functions From: Joe Perches To: Masami Hiramatsu Cc: Namhyung Kim , Stev Rostedt , Namhyung Kim , Hyeoncheol Lee , LKML , Srikar Dronamraju , Oleg Nesterov , "zhangwei(Jovi)" , Arnaldo Carvalho de Melo Date: Sun, 04 Aug 2013 23:31:57 -0700 In-Reply-To: <51FF4492.8080100@hitachi.com> References: <1375261410-11219-1-git-send-email-namhyung@kernel.org> <1375261410-11219-14-git-send-email-namhyung@kernel.org> <51FF4492.8080100@hitachi.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 23 On Mon, 2013-08-05 at 15:22 +0900, Masami Hiramatsu wrote: > (2013/07/31 18:03), Namhyung Kim wrote: > > From: Namhyung Kim > > > > The print format of s32 type was "ld" and it's casted to "long". So > > it turned out to print 4294967295 for "-1" on 64-bit systems. Not > > sure whether it worked well on 32-bit systems. [] > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c [] > > @@ -45,14 +45,19 @@ __kprobes int PRINT_TYPE_FUNC_NAME(type)(struct trace_seq *s, \ [] > > +DEFINE_BASIC_PRINT_TYPE_FUNC(s8, "%d", signed char) If there's a need to identify signed char, why not signed short, signed int and signd long too? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/