Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754178Ab3HEKXr (ORCPT ); Mon, 5 Aug 2013 06:23:47 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:58840 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909Ab3HEKXp (ORCPT ); Mon, 5 Aug 2013 06:23:45 -0400 Message-ID: <51FF7D2C.1090107@ti.com> Date: Mon, 5 Aug 2013 13:23:40 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: George Cherian CC: , , , , , , , , , Subject: Re: [PATCH 3/4] dts: dra7-evm: add USB support References: <1375369134-26398-1-git-send-email-rogerq@ti.com> <1375369134-26398-4-git-send-email-rogerq@ti.com> <51FBCA6F.9030503@ti.com> <51FF5A69.7040604@ti.com> <51FF6A45.3060702@ti.com> In-Reply-To: <51FF6A45.3060702@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2226 Lines: 62 On 08/05/2013 12:03 PM, George Cherian wrote: > On 8/5/2013 1:25 PM, Roger Quadros wrote: >> On 08/02/2013 06:04 PM, George Cherian wrote: >>> On 8/1/2013 8:28 PM, Roger Quadros wrote: >>>> Add USB drv_vbus pinctrl information and USB mode >>>> for the USB controller. >>>> >>>> Signed-off-by: Roger Quadros >>>> --- >>>> arch/arm/boot/dts/dra7-evm.dts | 22 ++++++++++++++++++++++ >>>> 1 files changed, 22 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts >>>> index cb0703c..acd3c09 100644 >>>> --- a/arch/arm/boot/dts/dra7-evm.dts >>>> +++ b/arch/arm/boot/dts/dra7-evm.dts >>>> @@ -18,3 +18,25 @@ >>>> reg = <0x80000000 0x60000000>; /* 1536 MB */ >>>> }; >>>> }; >>>> + >>>> +&dra7_pmx_core { >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = < >>>> + &usb_pins >>>> + >; >>>> + >>>> + usb_pins: pinmux_usb_pins { >>>> + pinctrl-single,pins = < >>>> + 0x280 0xc0000 /* usb1_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */ >>>> + 0x284 0xc0000 /* usb2_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */ >>>> + >; >>>> + }; >>>> +}; >>>> + >>>> +&dwc3_1 { >>>> + dr_mode = "otg"; >>> otg??? >> What's wrong there? >> please see >> Documentation/devicetree/bindings/usb/generic.txt >> >> we want it to operate in dual role mode and hence "otg" > > Am sorry for not being clear with my earlier comment. > I meant whether we have otg/ DRD working. Till then shouldnt we put either peripheral/host? Setting it to peripheral did not work and I don't think it is meant to be used as host port at all so no point in setting it has host. Users needing host support can always use usb2 port. The kit comes supplied with host adapter only for the usb2 (mini) port. So I think we should just leave usb1 port OTG, and get it to work somehow, at least in peripheral mode first. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/