Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753842Ab3HEO0R (ORCPT ); Mon, 5 Aug 2013 10:26:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61576 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802Ab3HEO0P (ORCPT ); Mon, 5 Aug 2013 10:26:15 -0400 Date: Mon, 5 Aug 2013 10:25:57 -0400 From: Vivek Goyal To: Tejun Heo Cc: lizefan@huawei.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Balbir Singh , Aristeu Rozanski , Matt Helsley , Jens Axboe Subject: Re: [PATCH 15/23] cgroup: make hierarchy iterators deal with cgroup_subsys_state instead of cgroup Message-ID: <20130805142557.GA6440@redhat.com> References: <1375393801-4817-1-git-send-email-tj@kernel.org> <1375393801-4817-16-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1375393801-4817-16-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1999 Lines: 52 On Thu, Aug 01, 2013 at 05:49:53PM -0400, Tejun Heo wrote: > cgroup is currently in the process of transitioning to using css > (cgroup_subsys_state) as the primary handle instead of cgroup in > subsystem API. For hierarchy iterators, this is beneficial because > > * In most cases, css is the only thing subsystems care about anyway. > > * On the planned unified hierarchy, iterations for different > subsystems will need to skip over different subtrees of the > hierarchy depending on which subsystems are enabled on each cgroup. > Passing around css makes it unnecessary to explicitly specify the > subsystem in question as css is intersection between cgroup and > subsystem > > * For the planned unified hierarchy, css's would need to be created > and destroyed dynamically independent from cgroup hierarchy. Having > cgroup core manage css iteration makes enforcing deref rules a lot > easier. > > Most subsystem conversions are straight-forward. Noteworthy changes > are > > * blkio: cgroup_to_blkcg() is no longer used. Removed. > > * freezer: cgroup_freezer() is no longer used. Removed. > > * devices: cgroup_to_devcgroup() is no longer used. Removed. > > Signed-off-by: Tejun Heo > Cc: Li Zefan > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Balbir Singh > Cc: Aristeu Rozanski > Cc: Matt Helsley > Cc: Vivek Goyal > Cc: Jens Axboe > --- > block/blk-cgroup.c | 8 +-- > block/blk-cgroup.h | 25 ++++----- > block/blk-throttle.c | 8 +-- Block bits look good to me. Acked-by: Vivek Goyal Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/