Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754497Ab3HEQQA (ORCPT ); Mon, 5 Aug 2013 12:16:00 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:51611 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754462Ab3HEQP5 (ORCPT ); Mon, 5 Aug 2013 12:15:57 -0400 From: Joel Fernandes To: Tony Lindgren , Sekhar Nori , Santosh Shilimkar , Sricharan R , Rajendra Nayak , Lokesh Vutla , Matt Porter , Grant Likely , Rob Herring , Vinod Koul , Dan Williams , Mark Brown , Benoit Cousson , Russell King , Arnd Bergmann , Olof Johansson , Balaji TK , Gururaja Hebbar , Chris Ball , Jason Kridner CC: Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux MMC List , Joel Fernandes Subject: [PATCH v3 10/12] dma: edma: Check if MAX_NR_SG is even in prep function Date: Mon, 5 Aug 2013 11:14:55 -0500 Message-ID: <1375719297-12871-11-git-send-email-joelf@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1375719297-12871-1-git-send-email-joelf@ti.com> References: <1375719297-12871-1-git-send-email-joelf@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 31 Splitting of MAX available slots into 2 sets of size MAX_NR_LS requires to the MAX_NR_SG function to be even. We ensure the same in prep function. Signed-off-by: Joel Fernandes --- drivers/dma/edma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 70923a2..061f0cf 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -354,6 +354,9 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( int src_bidx, dst_bidx, src_cidx, dst_cidx; int i, num_slots_needed; + if (MAX_NR_SG & 1) + dev_err(dev, "%s: MAX_NR_SG must be even\n", __func__); + if (unlikely(!echan || !sgl || !sg_len)) return NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/