Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753957Ab3HEQZM (ORCPT ); Mon, 5 Aug 2013 12:25:12 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:40320 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922Ab3HEQZI (ORCPT ); Mon, 5 Aug 2013 12:25:08 -0400 From: Kevin Hilman To: Wei Yongjun Cc: nm@ti.com, anton@enomsg.org, dwmw2@infradead.org, andrii.tseglytskyi@ti.com, jean.pihet@newoldbits.com, tony@atomide.com, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() References: <20130626130641.GA26920@kahuna> <877gh8nbpm.fsf@linaro.org> Date: Mon, 05 Aug 2013 09:25:04 -0700 In-Reply-To: (Wei Yongjun's message of "Fri, 12 Jul 2013 12:59:40 +0800") Message-ID: <87r4e8gl5r.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 40 Wei Yongjun writes: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > Acked-by: Nishanth Menon > --- > cc to linux-pm with Nishanth Menon's ACK Thanks, queued for v3.12. Kevin > --- > drivers/power/avs/smartreflex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c > index db9973b..c26acfc 100644 > --- a/drivers/power/avs/smartreflex.c > +++ b/drivers/power/avs/smartreflex.c > @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sr_info->base = devm_ioremap_resource(&pdev->dev, mem); > - if (IS_ERR(sr_info->base)) { > - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); > + if (IS_ERR(sr_info->base)) > return PTR_ERR(sr_info->base); > - } > > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/