Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754184Ab3HESQu (ORCPT ); Mon, 5 Aug 2013 14:16:50 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:34982 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753238Ab3HESQt (ORCPT ); Mon, 5 Aug 2013 14:16:49 -0400 Message-ID: <1375726607.4457.43.camel@edumazet-glaptop> Subject: Re: [PATCH] net/ipv4: fix the conditions of entering TCP_CA_Disorder state From: Eric Dumazet To: Dong Fang Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 05 Aug 2013 11:16:47 -0700 In-Reply-To: <1375749951-11230-1-git-send-email-yp.fangdong@gmail.com> References: <1375749951-11230-1-git-send-email-yp.fangdong@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 41 On Mon, 2013-08-05 at 20:45 -0400, Dong Fang wrote: > if have some packets loss by network, the kernel can't reach here, we can see > the tcp_time_to_recover() function: > > static bool tcp_time_to_recover(struct sock *sk, int flag) > { > struct tcp_sock *tp = tcp_sk(sk); > __u32 packets_out; > > /* Trick#1: The loss is proven. */ > if (tp->lost_out) > return true; > //... > } > > when it return true, the following condition will be failed: > > //... > if (!tcp_time_to_recover(sk, flag)) { > tcp_try_to_open(sk, flag, prior_unsacked); > return; > } > //... > I honestly do not understand this changelog, and how it is related to the patch. Also its not 'net/ipv4:' issue but 'tcp:' one Could you please explain the issue again ? Thanks ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/