From: Phil Carmody <phil.carmody@partner.samsung.com>
To: "'Joe Perches'" <joe@perches.com>
Cc: apw@canonical.com, linux-kernel@vger.kernel.org
References: <1375700932-2851-1-git-send-email-phil.carmody@partner.samsung.com>
 <1375750807.1968.20.camel@joe-AO722>
In-reply-to: <1375750807.1968.20.camel@joe-AO722>
Subject: RE: [PATCH 1/1] checkpatch: fix some whitespace issues caused by --fix
Date: Tue, 06 Aug 2013 11:05:52 +0300
Message-id: <000901ce927b$c5b74c80$5125e580$%carmody@partner.samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac6SQE2738SoIDseTjWPIS6OQcatfAAOryAw
Content-language: en-gb
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1457
Lines: 37

> On Mon, 2013-08-05 at 14:08 +0300, Phil Carmody wrote:
> > Lines with incorrect spacing around an operator, such as:
> >   bystander, correct,incorrect
> > would get "fixed" to
> >   bystander,correct, incorrect
> > as the correct argument as well as the incorrectly-spaced operator
> > were both being trimmed. The correct argument only needs to be right
> > trimmed.
> 
> Thanks for the patch, but I think it needs a different fix.

I think it's the right approach, but you're right, it doesn't
fix all the problems. However, in part that's because many 
copies of the string, or bits of it, are created, and when 
one copy is modified, the others don't replicate that change.

> Even after your patch the --fix option still makes a mess of several
> code spacing issues.

Indeed. Just seen - func(foo,&bar); becoming func(foo,  &bar);, 
as --fix wants to put a space both after the ',' and before the '&'.

> I'll work on it and propose something soonish.

It's very much a WIP - I'll send my bride-of-checkpatch to you 
as soon as I've written some blurb. It might be that the 
complexities inside checkpatch can't be overcome, and it's
easier to address the changes entirely in a separate script?

Phil


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/