Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756668Ab3HFWJt (ORCPT ); Tue, 6 Aug 2013 18:09:49 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:43168 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756364Ab3HFWJr (ORCPT ); Tue, 6 Aug 2013 18:09:47 -0400 MIME-Version: 1.0 In-Reply-To: <19655139.gpQFe0oLNI@flatron> References: <1373470926-19314-1-git-send-email-dianders@chromium.org> <1375825071-20922-1-git-send-email-dianders@chromium.org> <1375825071-20922-3-git-send-email-dianders@chromium.org> <19655139.gpQFe0oLNI@flatron> Date: Tue, 6 Aug 2013 15:09:46 -0700 X-Google-Sender-Auth: npFOE-_rZpUYeb57W3Hgf9_C1X8 Message-ID: Subject: Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT From: Doug Anderson To: Tomasz Figa Cc: Chris Ball , Olof Johansson , Jaehoon Chung , Seungwon Jeon , James Hogan , Grant Grundler , Alim Akhtar , Abhilash Kesavan , Kukjin Kim , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 31 Tomasz, On Tue, Aug 6, 2013 at 2:58 PM, Tomasz Figa wrote: >> +static int dw_mci_exynos_resume_noirq(struct device *dev) >> +{ >> + struct dw_mci *host = dev_get_drvdata(dev); >> + u32 clksel; >> + >> + clksel = mci_readl(host, CLKSEL); >> + if (clksel & SDMMC_CLKSEL_WAKEUP_INT) >> + mci_writel(host, CLKSEL, clksel); > > What about clock gating? Will the clock used for clocking this register be > always enabled when this gets called? Since this is just accessing and writing a register in the "Mobile Storage Host" block, I'd imagine that this should be the "biu" (bus interface unit) clock, right? The dw_mmc code grabs the biu clock at probe time and never lets it go. That means that we're OK as long as common clock framework has already restored clocks to normal operation by this time. Do you think that common clock framework might not have put the clocks back into order by the time "noirq" callbacks are executed? -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/