Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756511Ab3HFXlT (ORCPT ); Tue, 6 Aug 2013 19:41:19 -0400 Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:46777 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352Ab3HFXlR (ORCPT ); Tue, 6 Aug 2013 19:41:17 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(zz98dI936eI1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzzz2dh2a8h668h839h93fhd24hf0ah1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e23h1155h) Message-ID: <1375832471.5600.41.camel@snotra.buserror.net> Subject: Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries. From: Scott Wood To: Benjamin Herrenschmidt CC: Deepthi Dharwar , , , , , , , , , , Date: Tue, 6 Aug 2013 18:41:11 -0500 In-Reply-To: <1375831851.12557.74.camel@pasglop> References: <20130731025840.19448.24468.stgit@deepthi> <20130731025934.19448.16658.stgit@deepthi> <1375830520.5600.23.camel@snotra.buserror.net> <1375831851.12557.74.camel@pasglop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 24 On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote: > > Here's another example. get_lppaca() will only build on book3s -- and > > yet we get requests for e500 code to use this file. > > Indeed, Besides there is already accessors afaik for lppaca that compile > to nothing on E (and if not they would be trivial to add). I don't see such an accessor, but if there were, what would happen when the caller goes on to dereference that nothing? There is an accessor for shared_proc specifically (in the spinlock code) -- not that it would be much help on booke to just compile away that check and always select one of the pseries state tables over the other. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/