Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756692Ab3HGBBb (ORCPT ); Tue, 6 Aug 2013 21:01:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35650 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110Ab3HGBB3 (ORCPT ); Tue, 6 Aug 2013 21:01:29 -0400 Date: Wed, 7 Aug 2013 03:01:26 +0200 (CEST) From: Jiri Kosina To: Peter Wu Cc: linux-input@vger.kernel.org, Manoj Chourasia , linux-kernel@vger.kernel.org, alnovak@suse.cz Subject: Re: List corruption in hidraw_release in 3.11-rc4 In-Reply-To: <6712128.bn50J4si9x@al> Message-ID: References: <6712128.bn50J4si9x@al> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 41 On Tue, 6 Aug 2013, Peter Wu wrote: > While debugging upowerd (with Logitech Unifying receiver via hidraw), > I came across this list corruption warning. Peter, does the patch below fix the problem you are seeing? --- drivers/hid/hidraw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index a745163..6f1feb2 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -518,7 +518,6 @@ int hidraw_connect(struct hid_device *hid) goto out; } - mutex_unlock(&minors_lock); init_waitqueue_head(&dev->wait); INIT_LIST_HEAD(&dev->list); @@ -528,6 +527,7 @@ int hidraw_connect(struct hid_device *hid) dev->exist = 1; hid->hidraw = dev; + mutex_unlock(&minors_lock); out: return result; -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/