Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756964Ab3HGDZ5 (ORCPT ); Tue, 6 Aug 2013 23:25:57 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:44965 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756901Ab3HGDZ4 (ORCPT ); Tue, 6 Aug 2013 23:25:56 -0400 MIME-Version: 1.0 In-Reply-To: <5201A9BD.4090503@linux.vnet.ibm.com> References: <20130715164844.1520.27771.stgit@aruna-ThinkPad-T420> <51FA3B02.7060004@linux.vnet.ibm.com> <3908561D78D1C84285E8C5FCA982C28F31CAA167@ORSMSX106.amr.corp.intel.com> <51FFDC8B.7010909@linux.vnet.ibm.com> <51FFFFEB.3030907@linux.vnet.ibm.com> <5201A9BD.4090503@linux.vnet.ibm.com> Date: Tue, 6 Aug 2013 20:25:55 -0700 Message-ID: Subject: Re: [PATCH 00/11] Add compression support to pstore From: Tony Luck To: Aruna Balakrishnaiah Cc: "linuxppc-dev@ozlabs.org" , "paulus@samba.org" , "linux-kernel@vger.kernel.org" , "benh@kernel.crashing.org" , "keescook@chromium.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 22 On Tue, Aug 6, 2013 at 6:58 PM, Aruna Balakrishnaiah wrote: > The patch looks right. I will clean it up. Does the issue still persist > after this? Things seem to be working - but testing has hardly been extensive (just a couple of forced panics). I do have one other question. In this code: >> if (compressed && (type == PSTORE_TYPE_DMESG)) { >> big_buf_sz = (psinfo->bufsize * 100) / 45; Where does the magic multiply by 1.45 come from? Is that always enough for the decompression of "dmesg" type data to succeed? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/