Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238Ab3HGHpU (ORCPT ); Wed, 7 Aug 2013 03:45:20 -0400 Received: from mail.karo-electronics.de ([81.173.242.67]:62743 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788Ab3HGHpR (ORCPT ); Wed, 7 Aug 2013 03:45:17 -0400 Message-ID: <20993.64234.352390.254920@ipc1.ka-ro> Date: Wed, 7 Aug 2013 09:44:42 +0200 From: =?utf-8?Q?Lothar_Wa=C3=9Fmann?= To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Michal Hocko , Don Zickus , Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Andrew Morton Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: [BUG linux-next] watchdog: build breakage for non-SMP builds X-Mailer: VM 8.1.0 under 23.2.1 (x86_64-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 49 Hi, commit 0ce6966b "watchdog: update watchdog_tresh properly" breaks build on non-SMP systems (more specifically: on systems where CONFIG_USE_GENERIC_SMP_HELPERS is not set): linux-next/kernel/watchdog.c: In function 'update_timers': linux-next/kernel/watchdog.c:522:2: error: implicit declaration of function '__smp_call_function_single' [-Werror=implicit-function-declaration] I guess the offending code should be guarded by an '#ifdef CONFIG_USE_GENERIC_SMP_HELPERS' like in kernel/softirq.c: #ifdef CONFIG_USE_GENERIC_SMP_HELPERS [...] static int __try_remote_softirq(struct call_single_data *cp, int cpu, int softirq) { if (cpu_online(cpu)) { cp->func = remote_softirq_receive; cp->info = &softirq; cp->flags = 0; __smp_call_function_single(cpu, cp, 0); return 0; } return 1; } #else /* CONFIG_USE_GENERIC_SMP_HELPERS */ static int __try_remote_softirq(struct call_single_data *cp, int cpu, int softirq) { return 1; } #endif Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/