Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932411Ab3HGIAh (ORCPT ); Wed, 7 Aug 2013 04:00:37 -0400 Received: from mail-ee0-f52.google.com ([74.125.83.52]:43001 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756346Ab3HGIAg (ORCPT ); Wed, 7 Aug 2013 04:00:36 -0400 Date: Wed, 7 Aug 2013 09:00:30 +0100 From: Lee Jones To: Mike Turquette Cc: Yadwinder Singh Brar , Yadwinder Singh Brar , linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , sbkim73@samsung.com, Samuel Ortiz , Mark Brown Subject: Re: [PATCH 1/3] clk: s2mps11: Add support for s2mps11 Message-ID: <20130807080030.GI5100@lee--X1> References: <1373197462-4033-1-git-send-email-yadi.brar@samsung.com> <1373197462-4033-2-git-send-email-yadi.brar@samsung.com> <20130805232337.5348.79716@quantum> <20130806195235.5348.32684@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130806195235.5348.32684@quantum> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1569 Lines: 45 On Tue, 06 Aug 2013, Mike Turquette wrote: > Quoting Yadwinder Singh Brar (2013-08-05 21:25:44) > > Hi Mike, > > > > On Tue, Aug 6, 2013 at 4:53 AM, Mike Turquette wrote: > > > Quoting Yadwinder Singh Brar (2013-07-07 04:44:20) > > >> This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz > > >> outputs of mfd-s2mps11 with common clock framework. > > >> > > >> Signed-off-by: Yadwinder Singh Brar > > > > > > Yadwinder, > > > > > > Looks good to me with the exception of a binding description document. > > > Can you provide one and squash it into this commit? > > > > > > > Binding description is provided in next patch : > > [PATCH 2/3] mfd: sec: Add clock cell for s2mps11 : > > https://lkml.org/lkml/2013/7/16/228 > > > > Since its a MFD, so i preferred to add documentation in same file > > under mfd, same was done for regulators also. > > If its fine with you then, I think that patch can go through MFD tree > > as same file is touched in for-next of MFD tree. > > I see. Ok I've taken patch #1 into clk-next. Can you review the bindings in: mfd: sec: Add clock cell for s2mps11 ... please Mike? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/