Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932843Ab3HGK7g (ORCPT ); Wed, 7 Aug 2013 06:59:36 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:54063 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932496Ab3HGK7d (ORCPT ); Wed, 7 Aug 2013 06:59:33 -0400 MIME-Version: 1.0 In-Reply-To: <52022797.3060006@overkiz.com> References: <1375870466-1093-1-git-send-email-b.brezillon@overkiz.com> <52022797.3060006@overkiz.com> From: Richard Genoud Date: Wed, 7 Aug 2013 12:59:12 +0200 Message-ID: Subject: Re: [PATCH] ARM: at91/dt: split sam9x5 peripheral definitions To: boris brezillon Cc: Russell King , Nicolas Ferre , Jean-Christophe PLAGNIOL-VILLARD , Linus Walleij , Ludovic Desroches , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2518 Lines: 73 2013/8/7 boris brezillon : > Hello Richard, > > > On 07/08/2013 12:38, Richard Genoud wrote: >> >> 2013/8/7 Boris BREZILLON : >>> >>> This patch splits the sam9x5 peripheral definitions into: >>> - a common base for all sam9x5 SoCs (at91sam9x5.dtsi) >>> - several optional peripheral definitions which will be included by >>> specific >>> sam9x5 SoCs (at91sam9x5_'periph name'.dtsi) >>> >>> This provides a better representation of the real hardware (drop unneeded >>> dt nodes) and avoids future peripheral id conflict (lcdc and isi both use >>> peripheral id 25). >>> >>> Signed-off-by: Boris BREZILLON >>> --- >>> arch/arm/boot/dts/at91sam9g25.dtsi | 2 + >>> arch/arm/boot/dts/at91sam9g35.dtsi | 1 + >>> arch/arm/boot/dts/at91sam9x25.dtsi | 24 ++--------- >>> arch/arm/boot/dts/at91sam9x35.dtsi | 1 + >>> arch/arm/boot/dts/at91sam9x5.dtsi | 67 >>> ------------------------------ >>> arch/arm/boot/dts/at91sam9x5_macb0.dtsi | 56 >>> +++++++++++++++++++++++++ >>> arch/arm/boot/dts/at91sam9x5_macb1.dtsi | 44 ++++++++++++++++++++ >>> arch/arm/boot/dts/at91sam9x5_usart3.dtsi | 51 +++++++++++++++++++++++ >>> 8 files changed, 158 insertions(+), 88 deletions(-) >>> create mode 100644 arch/arm/boot/dts/at91sam9x5_macb0.dtsi >>> create mode 100644 arch/arm/boot/dts/at91sam9x5_macb1.dtsi >>> create mode 100644 arch/arm/boot/dts/at91sam9x5_usart3.dtsi >>> >> [snip] >>> >>> diff --git a/arch/arm/boot/dts/at91sam9x5_usart3.dtsi >>> b/arch/arm/boot/dts/at91sam9x5_usart3.dtsi >>> new file mode 100644 >>> index 0000000..5589579 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/at91sam9x5_usart3.dtsi >>> @@ -0,0 +1,51 @@ >>> +/* >>> + * at91sam9x5_lcdc.dtsi - Device Tree Include file for AT91SAM9x5 SoC >>> with >>> + * 4 USART. >> >> One minor comment mistake here ! > > Nice catch! > > I'll fix it for the next version. > > BTW did you test it (I didn't: I don't have any board with this SoC family) > ? Not yet, will do it ! > This separation was formerly done in the "at91 common clk" series but I > removed it > from the new version (which I will submit soon) to ease the review and > tests. > ok ! Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/