Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757442Ab3HGL37 (ORCPT ); Wed, 7 Aug 2013 07:29:59 -0400 Received: from service87.mimecast.com ([91.220.42.44]:60155 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757418Ab3HGL35 convert rfc822-to-8bit (ORCPT ); Wed, 7 Aug 2013 07:29:57 -0400 Message-ID: <52022FC2.2010109@arm.com> Date: Wed, 07 Aug 2013 12:30:10 +0100 From: Sudeep KarkadaNagesha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Viresh Kumar CC: Amit Daniel Kachhap , Kukjin Kim , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sudeep.KarkadaNagesha@arm.com Subject: Re: [PATCH] cpufreq: exynos5440: Fix to skip when new frequency same as current References: <1375874171-16951-1-git-send-email-amit.daniel@samsung.com> In-Reply-To: X-OriginalArrivalTime: 07 Aug 2013 11:29:53.0736 (UTC) FILETIME=[6FD05C80:01CE9361] X-MC-Unique: 113080712295403601 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 34 On 07/08/13 12:22, Viresh Kumar wrote: > On 7 August 2013 16:46, Amit Daniel Kachhap wrote: >> This patch fixes the issue of un-necessary setting the clock controller >> when the new target frequency is same as the current one. This case usually >> occurs with governors like ondemand which passes the target frequency as the >> percentage of average frequency. This check is present in most of the cpufreq >> driver. >> >> Cc: Viresh Kumar >> Cc: Rafael J. Wysocki >> Cc: Kukjin Kim >> Signed-off-by: Amit Daniel Kachhap >> --- >> drivers/cpufreq/exynos5440-cpufreq.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) > > Applied. Hi Viresh, Any particular reason we need this check in all drivers after your commit: 5a1c0228 "cpufreq: Avoid calling cpufreq driver's target() routine if target_freq == policy->cur" I think it can removed from all drivers, am I missing something ? Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/