Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757191Ab3HGRGK (ORCPT ); Wed, 7 Aug 2013 13:06:10 -0400 Received: from mail-qc0-f178.google.com ([209.85.216.178]:64171 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756738Ab3HGRGH (ORCPT ); Wed, 7 Aug 2013 13:06:07 -0400 MIME-Version: 1.0 In-Reply-To: <20130807163045.GK28558@e106331-lin.cambridge.arm.com> References: <1375812017-6287-1-git-send-email-jwerner@chromium.org> <20130807163045.GK28558@e106331-lin.cambridge.arm.com> Date: Wed, 7 Aug 2013 10:06:05 -0700 X-Google-Sender-Auth: MWyuZfEowOTrSW6e9aKGBSCefA4 Message-ID: Subject: Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling From: Julius Werner To: Mark Rutland Cc: Julius Werner , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Kukjin Kim , Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Tomasz Figa , Vivek Gautam , "devicetree@vger.kernel.org" , Sylwester Nawrocki Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 23 > This breaks compatibility, both for an old kernel and a new dt and a new > kernel with an old dt. Is anyone using these bindings? They only affect Samsung SoCs and have only been upstream for half a year, so I doubt it's heavily used. > Why are we describing fewer registers now? Are they described elsewhere? > > The dt should describe the device, not only the portion of it Linux > wants to use right now. This only ever described a small section of the huge set of PMU registers anyway. Before it described up to three registers controlling different PHYs (using hardcoded offsets in the code to later find the right one)... with my patch every PHY's DT entry only describes the one register concerning itself, which makes more sense in my opinion. It will also prevent the register descriptions in different DT entries from overlapping. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/