Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757229Ab3HGRQM (ORCPT ); Wed, 7 Aug 2013 13:16:12 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:51712 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754691Ab3HGRQL convert rfc822-to-8bit (ORCPT ); Wed, 7 Aug 2013 13:16:11 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Yadwinder Singh Brar , linux-kernel@vger.kernel.org From: Mike Turquette In-Reply-To: <1373197462-4033-3-git-send-email-yadi.brar@samsung.com> Cc: linux-arm-kernel@lists.infradead.org, sbkim73@samsung.com, sameo@linux.intel.com, lee.jones@linaro.org, broonie@kernel.org, yadi.brar01@gmail.com, Yadwinder Singh Brar References: <1373197462-4033-1-git-send-email-yadi.brar@samsung.com> <1373197462-4033-3-git-send-email-yadi.brar@samsung.com> Message-ID: <20130807171606.5348.76732@quantum> User-Agent: alot/0.3.4 Subject: Re: [PATCH 2/3] mfd: sec: Add clock cell for s2mps11 Date: Wed, 07 Aug 2013 10:16:06 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2885 Lines: 73 Quoting Yadwinder Singh Brar (2013-07-07 04:44:21) > This patch adds clock to list of mfd cells for s2mps11 and DT documentation > for clock part. > > Signed-off-by: Yadwinder Singh Brar Reviewed-by: Mike Turquette > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 20 ++++++++++++++++++++ > drivers/mfd/sec-core.c | 4 +++- > 2 files changed, 23 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 36269c4..e41dd16 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -16,6 +16,21 @@ Optional properties: > - interrupts: Interrupt specifiers for interrupt sources. > > Optional nodes: > +- clocks: s2mps11 provides three(AP/CP/BT) buffered 32.768 KHz outputs, so to > + register these as clocks with common clock framework instantiate a sub-node > + named "clocks". It uses the common clock binding documented in : > + [Documentation/devicetree/bindings/clock/clock-bindings.txt] > + - #clock-cells: should be 1. > + > + - The following is the list of clocks generated by the controller. Each clock > + is assigned an identifier and client nodes use this identifier to specify > + the clock which they consume. > + Clock ID > + ---------------------- > + 32KhzAP 0 > + 32KhzCP 1 > + 32KhzBT 2 > + > - regulators: The regulators of s2mps11 that have to be instantiated should be > included in a sub-node named 'regulators'. Regulator nodes included in this > sub-node should be of the format as listed below. > @@ -55,6 +70,11 @@ Example: > compatible = "samsung,s2mps11-pmic"; > reg = <0x66>; > > + s2m_osc: clocks{ > + #clock-cells = 1; > + clock-output-names = "xx", "yy", "zz"; > + }; > + > regulators { > ldo1_reg: LDO1 { > regulator-name = "VDD_ABB_3.3V"; > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 760da8a..eaee5ec 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -58,7 +58,9 @@ static struct mfd_cell s5m8767_devs[] = { > static struct mfd_cell s2mps11_devs[] = { > { > .name = "s2mps11-pmic", > - }, > + }, { > + .name = "s2mps11-clk", > + } > }; > > #ifdef CONFIG_OF > -- > 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/