Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932436Ab3HGRpP (ORCPT ); Wed, 7 Aug 2013 13:45:15 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:49997 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756780Ab3HGRpM (ORCPT ); Wed, 7 Aug 2013 13:45:12 -0400 MIME-Version: 1.0 In-Reply-To: <52028620.6000608@wwwdotorg.org> References: <8d192a13cb7e088943da40689d62bc6353bd8604.1375886595.git.viresh.kumar@linaro.org> <52028620.6000608@wwwdotorg.org> Date: Wed, 7 Aug 2013 23:15:11 +0530 Message-ID: Subject: Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver From: Viresh Kumar To: Stephen Warren Cc: rjw@sisk.pl, swarren@nvidia.com, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 25 On 7 August 2013 23:08, Stephen Warren wrote: > On 08/07/2013 08:46 AM, Viresh Kumar wrote: >> This patch adds CPU0's clk driver for Tegra. It will be used by the generic >> cpufreq-cpu0 driver to get/set cpu clk. >> >> Most of the platform specific bits are picked from tegra-cpufreq.c. > > Hmmm. I'm not sure if it makes sense to represent this as a clock > object; isn't this more of a virtual construct that manages the rate of > the clock, rather than an actual clock? The actual clock already exists > as "cpu". I see it as this: There is a clock in system for cpu, call it "cpu". Now we must be able to provide get/set routines for it. A set should set the frequency to whatever is asked for and should really worry about how that is being set. This part is internal to "cpu" clk. This is what cpufreq-cpu0 driver should expect and does. Current "cpu" clock implemented doesn't provide this facility ? And so this wrapper made sense to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/