Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932975Ab3HGR7N (ORCPT ); Wed, 7 Aug 2013 13:59:13 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:60423 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932684Ab3HGR7K (ORCPT ); Wed, 7 Aug 2013 13:59:10 -0400 MIME-Version: 1.0 In-Reply-To: <5202898A.6050006@wwwdotorg.org> References: <6610c86618b781b00eba446ca19035e077d99691.1375886595.git.viresh.kumar@linaro.org> <520287EA.5060508@wwwdotorg.org> <5202898A.6050006@wwwdotorg.org> Date: Wed, 7 Aug 2013 23:29:10 +0530 Message-ID: Subject: Re: [PATCH 5/6] ARM: Tegra: start using cpufreq-cpu0 driver From: Viresh Kumar To: Stephen Warren Cc: rjw@sisk.pl, swarren@nvidia.com, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 28 On 7 August 2013 23:23, Stephen Warren wrote: > That link only describes why we shouldn't have a dedicated compatible > value for cpufreq. I certainly agree with that. However, I think it's > reasonable that whatever code binds to: > > compatible = "arm,cortex-a9"; > > ... should instantiate any virtual devices that relate to the CPU. But how would we know here if platform really wants us to probe cpufreq-cpu0 driver? On multiplatform kernel there can be multiple cpufreq drivers available and there has to be some sort of code in DT or platform code that reflects which driver we want to use. We never required a device node for cpufreq, platform device was added just to solve this issue. > Doing so would be similar to how the Tegra I2S driver instantiates the > internal struct device that ASoC needs for the PCM/DMA device, rather > than having board-dt-tegra20.c do it, like it would have done in > board-file days. I haven't gone through it yet though :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/