Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965254Ab3HHOSb (ORCPT ); Thu, 8 Aug 2013 10:18:31 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46291 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757850Ab3HHOS3 (ORCPT ); Thu, 8 Aug 2013 10:18:29 -0400 Date: Thu, 8 Aug 2013 16:16:31 +0200 From: Andrew Lunn To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Lunn Subject: Re: [PATCH 17/35] cpufreq: kirkwood: use cpufreq_table_validate_and_show() Message-ID: <20130808141631.GG29815@lunn.ch> References: <8b7f30f52b99c21697168d77f1fae298dad50226.1375964117.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b7f30f52b99c21697168d77f1fae298dad50226.1375964117.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 47 On Thu, Aug 08, 2013 at 07:18:19PM +0530, Viresh Kumar wrote: > Lets use cpufreq_table_validate_and_show() instead of calling > cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). > > Cc: Andrew Lunn > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/kirkwood-cpufreq.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c > index 45e4d7f..336f171 100644 > --- a/drivers/cpufreq/kirkwood-cpufreq.c > +++ b/drivers/cpufreq/kirkwood-cpufreq.c > @@ -125,19 +125,11 @@ static int kirkwood_cpufreq_target(struct cpufreq_policy *policy, > /* Module init and exit code */ > static int kirkwood_cpufreq_cpu_init(struct cpufreq_policy *policy) > { > - int result; > - > /* cpuinfo and default policy values */ > policy->cpuinfo.transition_latency = 5000; /* 5uS */ > policy->cur = kirkwood_cpufreq_get_cpu_frequency(0); > > - result = cpufreq_frequency_table_cpuinfo(policy, kirkwood_freq_table); > - if (result) > - return result; > - > - cpufreq_frequency_table_get_attr(kirkwood_freq_table, policy->cpu); > - > - return 0; > + return cpufreq_table_validate_and_show(policy, kirkwood_freq_table); > } > > static int kirkwood_cpufreq_cpu_exit(struct cpufreq_policy *policy) > -- > 1.7.12.rc2.18.g61b472e Reviewed-by: Andrew Lunn Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/