Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965980Ab3HHSG5 (ORCPT ); Thu, 8 Aug 2013 14:06:57 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:47908 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497Ab3HHSGz (ORCPT ); Thu, 8 Aug 2013 14:06:55 -0400 MIME-Version: 1.0 In-Reply-To: <20130808092615.GF14648@e106331-lin.cambridge.arm.com> References: <1375812017-6287-1-git-send-email-jwerner@chromium.org> <20130807163045.GK28558@e106331-lin.cambridge.arm.com> <20130808092615.GF14648@e106331-lin.cambridge.arm.com> Date: Thu, 8 Aug 2013 11:06:54 -0700 X-Google-Sender-Auth: k0NIGgMv6Uws0san_OE_Yb6a97Q Message-ID: Subject: Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling From: Julius Werner To: Mark Rutland Cc: Julius Werner , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Kukjin Kim , Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Tomasz Figa , Vivek Gautam , "devicetree@vger.kernel.org" , Sylwester Nawrocki Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 25 > I'm not sure I understand. The old documentation referred to the > USBDEVICE_PHY_CONTROL and USBHOST_PHY_CONTROL registers for a phy, and > your new version only refers to (usb device) PHY_CONTROL. Regardless of > multiple phys, you're suggesting that we describe less of each phy. > That seems like taking away usable information. Unless I've > misunderstood? Well that's just the thing that's confusing right now, and which I am trying to fix: every PHY is either DEVICE or HOST and thus has only one PMU register. The current code describes the PMU register space for all PHYs on the system in the DT entry of every PHY and then calculates which register to use with hardcoded offsets. I think it makes much more sense if every PHY only describes its own register and doesn't need to do address arithmetic later on. As Vivek said there is one exception in an old Exynos4, but that is currently not implemented in the upstream kernel anyway, and if it ever will be it's still much easier to special case one weird chip than to have a super complicated and confusing mechanism for all of them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/