Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966747Ab3HHVdj (ORCPT ); Thu, 8 Aug 2013 17:33:39 -0400 Received: from mail.active-venture.com ([67.228.131.205]:55963 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966702Ab3HHVdi (ORCPT ); Thu, 8 Aug 2013 17:33:38 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <52040EB9.2050908@roeck-us.net> Date: Thu, 08 Aug 2013 14:33:45 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Stephen Warren CC: Sergei Shtylyov , Wei Ni , khali@linux-fr.org, linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, MLongnecker@nvidia.com, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008 References: <1375944991-29182-1-git-send-email-wni@nvidia.com> <1375944991-29182-3-git-send-email-wni@nvidia.com> <52040146.7060703@cogentembedded.com> <52040236.2080701@wwwdotorg.org> In-Reply-To: <52040236.2080701@wwwdotorg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1771 Lines: 47 On 08/08/2013 01:40 PM, Stephen Warren wrote: > On 08/08/2013 02:36 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 08/08/2013 10:56 AM, Wei Ni wrote: >> >>> Enable thermal sensor nct1008 for t114 dalmore. >> >>> Signed-off-by: Wei Ni >>> --- >>> arch/arm/boot/dts/tegra114-dalmore.dts | 10 +++++++++- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >> >>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts >>> b/arch/arm/boot/dts/tegra114-dalmore.dts >>> index b5a42f0..9d4d2b2 100644 >>> --- a/arch/arm/boot/dts/tegra114-dalmore.dts >>> +++ b/arch/arm/boot/dts/tegra114-dalmore.dts >>> @@ -738,6 +738,14 @@ >>> realtek,ldo1-en-gpios = >>> <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>; >>> }; >>> + >>> + nct1008 { >> >> ePAPR [1] says: "the name of a node should be somewhat generic, >> reflecting the function of the device and not its precise programming >> model". So I suggest "thermal" > > True, although there's quite some precedent for node-names being the > chip name for external chips in existing DTs. If we change this node > name, I'd like to see a patch that makes all the other "nct1008" nodes > match the new name... > On the other side, one should not use a bad example as an argument or excuse to make the same mistake again (though I keep hearing it all the time ... ). I for my part tend to use something like temp-sensor or temp-sensor@1c. Advantage of that kind of node name is that it auto-describes the node. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/