Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966788Ab3HHWV1 (ORCPT ); Thu, 8 Aug 2013 18:21:27 -0400 Received: from etezian.org ([198.101.225.253]:51873 "EHLO mail.etezian.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965419Ab3HHWV0 (ORCPT ); Thu, 8 Aug 2013 18:21:26 -0400 Date: Fri, 9 Aug 2013 00:21:08 +0200 From: Andi Shyti To: Greg KH Cc: Andi Shyti , oatilla@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] etzkx accelerometer support Message-ID: <20130808222108.GC11387@jack.whiskey> References: <20130616215110.GA10834@kroah.com> <20130616222648.GE4385@jack.whiskey> <20130617025854.GB12522@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130617025854.GB12522@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 33 Hi Greg, > > > > these two patches provide the etzkx device driver which supports > > > > the following accelerometers: > > > > > > Why isn't this a drivers/iio/accel/ driver instead of a misc driver? > > > Please make this an iio driver, then you will be using the correct > > > user/kernel api to talk to your device. > > > > I was thinking it may be an issue, but it's not iio because the > > time I developed the driver, iio was in the first staging period > > and mainly because the on the board I'm using I cannot update the > > Kernel to use the latest iio. > > > > I guess you don't like the promise "I can do it later" once the > > supplier sends me a development board (which is planned) :) > > Sure, I'll gladly accept "I can do it later" from anyone, as long as you > don't mind my, "I will merge it later" as well :) > > Sorry, I can't accept a driver now, that is known to going to be > changing the kernel/user api in the future. So please, rewrite it to > use IIO, that's what that interface / subsystem is there for. What about submitting this accelerometer driver under staging even if it's still not iio and slowly put it in shape? Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/