Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967300Ab3HICrW (ORCPT ); Thu, 8 Aug 2013 22:47:22 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:41037 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753233Ab3HICrU (ORCPT ); Thu, 8 Aug 2013 22:47:20 -0400 X-IronPort-AV: E=Sophos;i="4.89,843,1367942400"; d="scan'208";a="8159369" Message-ID: <52045747.2060207@cn.fujitsu.com> Date: Fri, 09 Aug 2013 10:43:19 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Yasuaki Ishimatsu CC: rafael.j.wysocki@intel.com, toshi.kani@hp.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() References: <5200CBBF.1090904@jp.fujitsu.com> In-Reply-To: <5200CBBF.1090904@jp.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/09 10:45:51, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/09 10:45:52, Serialize complete at 2013/08/09 10:45:52 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-2022-JP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2176 Lines: 65 Hi Ishimatsu-san, On 08/06/2013 06:11 PM, Yasuaki Ishimatsu wrote: > try_offline_node() checks that all cpus related with removed node have been > removed by using cpu_present_bits. If all cpus related with removed node have > been removed, try_offline_node() clears the node information. > > But try_offline_node() called from acpi_processor_remove() never clears > the node information. For disabling cpu_present_bits, acpi_unmap_lsapic() > need be called. But acpi_unmap_lsapic() is called after try_offline_node() > runs. So when try_offline_node() runs, the cpu's cpu_present_bits is always > set. > > This patch moves try_offline_node() after acpi_unmap_lsapic(). It works well. > > Signed-off-by: Yasuaki Ishimatsu Tested-by: Gu Zheng Thanks, Gu > --- > drivers/acpi/acpi_processor.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c > index fd6c51c..5a74a9c 100644 > --- a/drivers/acpi/acpi_processor.c > +++ b/drivers/acpi/acpi_processor.c > @@ -451,7 +451,6 @@ static void acpi_processor_remove(struct acpi_device *device) > /* Clean up. */ > per_cpu(processor_device_array, pr->id) = NULL; > per_cpu(processors, pr->id) = NULL; > - try_offline_node(cpu_to_node(pr->id)); > > /* Remove the CPU. */ > get_online_cpus(); > @@ -459,6 +458,8 @@ static void acpi_processor_remove(struct acpi_device *device) > acpi_unmap_lsapic(pr->id); > put_online_cpus(); > > + try_offline_node(cpu_to_node(pr->id)); > + > out: > free_cpumask_var(pr->throttling.shared_cpu_map); > kfree(pr); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/