Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967343Ab3HICwN (ORCPT ); Thu, 8 Aug 2013 22:52:13 -0400 Received: from mail-qc0-f172.google.com ([209.85.216.172]:52088 "EHLO mail-qc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758252Ab3HICwK (ORCPT ); Thu, 8 Aug 2013 22:52:10 -0400 MIME-Version: 1.0 In-Reply-To: <1729120.r596vOTlMW@flatron> References: <1375812017-6287-1-git-send-email-jwerner@chromium.org> <20130808092615.GF14648@e106331-lin.cambridge.arm.com> <1729120.r596vOTlMW@flatron> Date: Thu, 8 Aug 2013 19:52:09 -0700 X-Google-Sender-Auth: pKio9Zr17KGbVbvVJcCfq65m320 Message-ID: Subject: Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling From: Julius Werner To: Tomasz Figa Cc: Julius Werner , Mark Rutland , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Kukjin Kim , Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Tomasz Figa , Vivek Gautam , "devicetree@vger.kernel.org" , Sylwester Nawrocki Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 19 > Sorry, I don't understand what is not implemented. Without your patch, the > PHY driver handles both PMU registers of Exynos4. I don't have an Exynos4 to actually test this, so please let me know if I'm missing something here... but in order to hit the right HOST PHY register in the current upstream code, the Exynos4 code would need to have a hostphy_reg_offset of 4 somewhere in its samsung_usbphy_drvdata. In my latest checkout of Linus' tree (6c2580c) it does not (only Exynos5 sets that attribute), so it would default to 0 (thereby actually hitting the DEVICE register). If you want I can gladly provide another change on top of my patchset to fix that in the future... but it looks to me like it had been broken anyway for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/