Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966401Ab3HIJcG (ORCPT ); Fri, 9 Aug 2013 05:32:06 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:59885 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965770Ab3HIJ1M (ORCPT ); Fri, 9 Aug 2013 05:27:12 -0400 X-AuditID: 9c930197-b7b44ae00000347f-9f-5204b5eb12e7 From: Joonsoo Kim To: Andrew Morton Cc: Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Wanpeng Li , Naoya Horiguchi , Hillf Danton , Joonsoo Kim Subject: [PATCH v2 05/20] mm, hugetlb: grab a page_table_lock after page_cache_release Date: Fri, 9 Aug 2013 18:26:23 +0900 Message-Id: <1376040398-11212-6-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 32 We don't need to grab a page_table_lock when we try to release a page. So, defer to grab a page_table_lock. Reviewed-by: Naoya Horiguchi Signed-off-by: Joonsoo Kim diff --git a/mm/hugetlb.c b/mm/hugetlb.c index c017c52..6c8eec2 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2627,10 +2627,11 @@ retry_avoidcopy: } spin_unlock(&mm->page_table_lock); mmu_notifier_invalidate_range_end(mm, mmun_start, mmun_end); - /* Caller expects lock to be held */ - spin_lock(&mm->page_table_lock); page_cache_release(new_page); page_cache_release(old_page); + + /* Caller expects lock to be held */ + spin_lock(&mm->page_table_lock); return 0; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/