Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967722Ab3HIN2M (ORCPT ); Fri, 9 Aug 2013 09:28:12 -0400 Received: from mail-qe0-f48.google.com ([209.85.128.48]:57141 "EHLO mail-qe0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966041Ab3HIN2L (ORCPT ); Fri, 9 Aug 2013 09:28:11 -0400 MIME-Version: 1.0 In-Reply-To: <20130809153730.83d3a5ba419def5424bcbb0e@samsung.com> References: <002b01ce941b$160a88a0$421f99e0$@samsung.com> <5396565.vjlSOm37Vf@flatron> <20130809153730.83d3a5ba419def5424bcbb0e@samsung.com> Date: Fri, 9 Aug 2013 08:28:09 -0500 Message-ID: Subject: Re: [PATCH v9 07/16] iommu/exynos: support for device tree From: Rob Herring To: Cho KyongHo Cc: Tomasz Figa , Linux ARM Kernel , Linux IOMMU , Linux Kernel , Linux Samsung SOC , "devicetree@vger.kernel.org" , Joerg Roedel , Kukjin Kim , Prathyush , Rahul Sharma , Subash Patel , Grant Grundler , Antonios Motakis , kvmarm@lists.cs.columbia.edu, Sachin Kamat Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 48 On Fri, Aug 9, 2013 at 1:37 AM, Cho KyongHo wrote: > On Fri, 09 Aug 2013 00:41:25 +0200, Tomasz Figa wrote: >> Hi KyongHo, >> >> On Thursday 08 of August 2013 18:38:49 Cho KyongHo wrote: >> > This commit adds device tree support for System MMU. >> > This also include the following changes and enhancements: >> > >> > * use managed device helper functions. >> > Simplyfies System MMU device driver. >> > >> > * use only a single clock descriptor. >> > System MMU device descriptor is seperate if it is imposible to make >> > a single clock descriptor to make a device descriptor for a group of >> > System MMUs. >> > >> > * removed dbgname member from sysmmu_drvdata structure. >> > debugging kernel message for a System MMU is distinguisheable with the >> > name of device descroptors. >> >> Please put all these three changes in separate patches. This patch is hard >> to review with all the changes mixed together... Agreed. >> > > Ok. > >> In addition, I believe this is the patch that should be adding device tree >> binding documentation, not the 6/16 one, as this is where actually support >> for this binding gets added to the kernel. > > Oh, I didn't know that devicetree binding description and implementation need > to be in the same patch. > I will do as you advised. Actually, I prefer the binding docs be separate patches. The reason being so we can get closer to having them in a separate repository. Also, then the binding can be acked separately from the kernel implementation using the binding. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/