Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968086Ab3HIQ3D (ORCPT ); Fri, 9 Aug 2013 12:29:03 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:57457 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967927Ab3HIQ3A (ORCPT ); Fri, 9 Aug 2013 12:29:00 -0400 Date: Fri, 9 Aug 2013 17:28:49 +0100 From: Mark Rutland To: Kumar Gala Cc: "balbi@ti.com" , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding Message-ID: <20130809162848.GW27325@e106331-lin.cambridge.arm.com> References: <1376062832-23288-1-git-send-email-galak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376062832-23288-1-git-send-email-galak@codeaurora.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 31 On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote: > The binding spec wasn't clear that the order of the phandles in the > usb-phy array has meaning. Clarify this point in the binding that > it should be . > > Signed-off-by: Kumar Gala > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 7a95c65..8a9770b 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -6,7 +6,9 @@ Required properties: > - compatible: must be "synopsys,dwc3" > - reg : Address and length of the register set for the device > - interrupts: Interrupts used by the dwc3 controller. > - - usb-phy : array of phandle for the PHY device > + - usb-phy : array of phandle for the PHY device. The first element > + in the array is expected to be a handle to the USB2/HS PHY and > + the second element is expected to be a handle to the USB3/SS PHY Just to check - it's not valid to have a USB3 phy without a USB2 phy? Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/