Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968156Ab3HIQmB (ORCPT ); Fri, 9 Aug 2013 12:42:01 -0400 Received: from mail-vc0-f170.google.com ([209.85.220.170]:36959 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968090Ab3HIQl7 (ORCPT ); Fri, 9 Aug 2013 12:41:59 -0400 MIME-Version: 1.0 In-Reply-To: <1376066000-5495-3-git-send-email-dianders@chromium.org> References: <1375825071-20922-1-git-send-email-dianders@chromium.org> <1376066000-5495-1-git-send-email-dianders@chromium.org> <1376066000-5495-3-git-send-email-dianders@chromium.org> Date: Fri, 9 Aug 2013 13:41:58 -0300 Message-ID: Subject: Re: [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT From: Fabio Estevam To: Doug Anderson Cc: Chris Ball , linux-samsung-soc@vger.kernel.org, James Hogan , Seungwon Jeon , linux-kernel@vger.kernel.org, Olof Johansson , linux-mmc@vger.kernel.org, Tomasz Figa , Jaehoon Chung , Grant Grundler , Kukjin Kim , Alim Akhtar , Abhilash Kesavan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 32 On Fri, Aug 9, 2013 at 1:33 PM, Doug Anderson wrote: > +#else > +#define dw_mci_exynos_suspend NULL > +#define dw_mci_exynos_resume NULL > +#define dw_mci_exynos_resume_noirq NULL > +#endif /* CONFIG_PM_SLEEP */ You could avoid this else block if you use 'static SIMPLE_DEV_PM_OPS' below. > + > static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) > { > /* > @@ -187,13 +234,20 @@ static int dw_mci_exynos_probe(struct platform_device *pdev) > return dw_mci_pltfm_register(pdev, drv_data); > } > > +const struct dev_pm_ops dw_mci_exynos_pmops = { > + SET_SYSTEM_SLEEP_PM_OPS(dw_mci_exynos_suspend, dw_mci_exynos_resume) > + .resume_noirq = dw_mci_exynos_resume_noirq, > + .thaw_noirq = dw_mci_exynos_resume_noirq, > + .restore_noirq = dw_mci_exynos_resume_noirq, > +}; static SIMPLE_DEV_PM_OPS(dw_mci_exynos_pmops, dw_mci_exynos_suspend, dw_mci_exynos_resume ) ; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/