Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968327Ab3HJBBY (ORCPT ); Fri, 9 Aug 2013 21:01:24 -0400 Received: from netrider.rowland.org ([192.131.102.5]:56278 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S968303Ab3HJBBX (ORCPT ); Fri, 9 Aug 2013 21:01:23 -0400 Date: Fri, 9 Aug 2013 21:01:22 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: David Daney cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , , David Daney Subject: Re: [PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out side of the ifs. In-Reply-To: <1376093837-24561-1-git-send-email-ddaney.cavm@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 30 On Fri, 9 Aug 2013, David Daney wrote: > From: David Daney > > When CONFIG_USB_SUPPORT is not selected we get things like: > > scripts/kconfig/mconf Kconfig > warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB) > > It is much cleaner to make the various system Kconfigs select > USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config > information into USB's Kconfig, but the warnings are annoying. > > Eliminate the warning by moving the definition of > USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements. This is a good thing to do, but you should also move USB_EHCI_BIG_ENDIAN_DESC. And while you're at it, might as well move USB_OHCI_BIG_ENDIAN_DESC, USB_OHCI_BIG_ENDIAN_MMIO, and USB_OHCI_LITTLE_ENDIAN outside their "if" blocks. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/