Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: [PATCH 3/3 V4] EDAC, AMD64_EDAC: Add ECC decoding support for newer F15h models.
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
In-Reply-To: <20130810151530.GA4155@pd.tnic>
Date: Sat, 10 Aug 2013 13:28:44 -0500
CC: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
        <dougthompson@xmission.com>, <bhelgaas@google.com>,
        <jbeulich@suse.com>, <linux-kernel@vger.kernel.org>,
        <linux-edac@vger.kernel.org>, <linux-pci@vger.kernel.org>
Content-Transfer-Encoding: 7bit
Message-ID: <1C4E3222-0A71-4603-BA8B-AAEF2924D30B@amd.com>
References: <1376067289-2753-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20130810151530.GA4155@pd.tnic>
To: Borislav Petkov <bp@alien8.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1904
Lines: 57


On Aug 10, 2013, at 10:15 AM, Borislav Petkov <bp@alien8.de>
wrote:

> On Fri, Aug 09, 2013 at 11:54:49AM -0500, Aravind Gopalakrishnan wrote:
>> Adding support for handling ECC error decoding for new F15 models.
>> On newer models, support has been included for upto 4 DCT's, however,
>> only DCT0 and DCT3 are currently configured. (Refer BKDG Section 2.10)
>> Routing DRAM Requests algorithm is different for F15h M30h.
>> It is cleaner to use a brand new function rather than
>> adding quirks in the more generic 'f1x_match_to_this_node'
>> Refer "2.10.5 DRAM Routing Requests" in BKDG for info.
>> 
>> Tested on Fam15h M30h with ECC turned on using mce_amd_inj facility and
>> verified to be functionally correct.
>> 
>> Changes from V3:
>> 	- Remove compiler warnings
>>      - Recheck models that need erratum workaround for E505:
>> 	  - From looking up history of the bug, we find that
>>          the workaround holds true only for Fam15 models upto 1h
>>          and only upto stepping 0h. CPU revisions after these
>>          do not need the workaround.
>> 
>> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> 
> Ok, I've taken it and applied a cleanup ontop which uses the locally
> cached family, model, stepping (sending it as a reply to this message).
> 
> I'd appreciate it if you tested the branch here
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git amd-f15-m30
> 
> just to make sure everything is still kosher.
> 

Thanks!
I have tested the branch and it works fine.

-Aravind. 

> Thanks.
> 
> -- 
> Regards/Gruss,
>  Boris.
> 
> Sent from a fat crate under my desk. Formatting is fine.
> --
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/