Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754178Ab3HKP5e (ORCPT ); Sun, 11 Aug 2013 11:57:34 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:42311 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753936Ab3HKP5c (ORCPT ); Sun, 11 Aug 2013 11:57:32 -0400 Date: Sun, 11 Aug 2013 17:56:40 +0200 From: Francois Romieu To: Julia Lawall Cc: grant.likely@linaro.org, rob.herring@calxeda.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: question about netif_rx Message-ID: <20130811155640.GA10070@electric-eye.fr.zoreil.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 24 Julia Lawall : > To my limited understanding, in a NAPI polling function, one should use > netif_receive_skb, rather than netif_rx. Nit: or napi_gro_receive (+ napi_gro_flush with __napi_complete) when the device offers some checksum offloading features. > However, the via-velocity driver defines the NAPI polling function > velocity_poll, which is the only caller of velocity_rx_srv, which > is the only caller of velocity_receive_frame, which calls netif_rx. > The call to netif_rx seems to predate the introduction of NAPI in > this driver. Is this correct? You are right. It's a leftover of the NAPI changes in this driver. Can you send a netif_receive_skb replacement patch for it ? -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/