Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619Ab3HLEcK (ORCPT ); Mon, 12 Aug 2013 00:32:10 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:42845 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753344Ab3HLEcI (ORCPT ); Mon, 12 Aug 2013 00:32:08 -0400 Date: Mon, 12 Aug 2013 10:01:59 +0530 From: Ananth N Mavinakayanahalli To: Andi Kleen Cc: linux-kernel@vger.kernel.org, mmarek@suse.cz, linux-kbuild@vger.kernel.org, Joe Mario , Andi Kleen Subject: Re: [PATCH 3/3] kprobes: Use KSYM_NAME_LEN to size identifier buffers Message-ID: <20130812043159.GA9278@in.ibm.com> Reply-To: ananth@in.ibm.com References: <1376182533-17530-1-git-send-email-andi@firstfloor.org> <1376182533-17530-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376182533-17530-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13081204-7408-0000-0000-000012E6812B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 46 On Sat, Aug 10, 2013 at 05:55:33PM -0700, Andi Kleen wrote: > From: Joe Mario > > Use KSYM_NAME_LEN to size identifier buffers, so that it can > be easier increased. > > Cc: ananth@in.ibm.com > Signed-off-by: Joe Mario > Signed-off-by: Andi Kleen Acked-by: Ananth N Mavinakayanahalli > --- > kernel/kprobes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 6e33498..e174daf 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -2083,7 +2083,7 @@ static int __init init_kprobes(void) > { > int i, err = 0; > unsigned long offset = 0, size = 0; > - char *modname, namebuf[128]; > + char *modname, namebuf[KSYM_NAME_LEN]; > const char *symbol_name; > void *addr; > struct kprobe_blackpoint *kb; > @@ -2209,7 +2209,7 @@ static int __kprobes show_kprobe_addr(struct seq_file *pi, void *v) > const char *sym = NULL; > unsigned int i = *(loff_t *) v; > unsigned long offset = 0; > - char *modname, namebuf[128]; > + char *modname, namebuf[KSYM_NAME_LEN]; > > head = &kprobe_table[i]; > preempt_disable(); > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/