Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755855Ab3HLGHx (ORCPT ); Mon, 12 Aug 2013 02:07:53 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:49963 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754326Ab3HLGHp (ORCPT ); Mon, 12 Aug 2013 02:07:45 -0400 MIME-Version: 1.0 In-Reply-To: <20130810082333.GA27640@samfundet.no> References: <20130810082333.GA27640@samfundet.no> Date: Mon, 12 Aug 2013 11:37:45 +0530 Message-ID: Subject: Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines From: Viresh Kumar To: Hans-Christian Egtvedt Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 31 On 10 August 2013 13:53, Hans-Christian Egtvedt wrote: > Around Sat 10 Aug 2013 12:14:07 +0530 or thereabout, Viresh Kumar wrote: >> Most of the CPUFreq drivers do similar things in .exit() and .verify() routines >> and .attr. So its better if we have generic routines for them which can be used >> by cpufreq drivers then. >> >> This patch uses these generic routines for this driver. > > Nice, thanks for cleaning up (-: > >> Cc: Hans-Christian Egtvedt >> Signed-off-by: Viresh Kumar > > Acked-by: Hans-Christian Egtvedt Thanks for your Ack but I have to NACK it :) My patch was wrong.. It was based on the assumption that everybody who had implemented a .target() also implements a frequency table and exposes it.. And the generic routines I have exposed depend on that frequency table. And this cpufreq driver doesn't expose that freq table... And so this patch is dropped :( -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/