Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755846Ab3HLGIS (ORCPT ); Mon, 12 Aug 2013 02:08:18 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:49231 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754530Ab3HLGIP (ORCPT ); Mon, 12 Aug 2013 02:08:15 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 12 Aug 2013 11:38:14 +0530 Message-ID: Subject: Re: [PATCH 43/44] cpufreq: unicore2: Use generic cpufreq routines From: Viresh Kumar To: rjw@sisk.pl Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar , Guan Xuetao Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 24 On 10 August 2013 12:14, Viresh Kumar wrote: > Most of the CPUFreq drivers do similar things in .exit() and .verify() routines > and .attr. So its better if we have generic routines for them which can be used > by cpufreq drivers then. > > This patch uses these generic routines for this driver. > > Cc: Guan Xuetao > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/unicore2-cpufreq.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) My patch was wrong.. It was based on the assumption that everybody who had implemented a .target() also implements a frequency table and exposes it.. And the generic routines I have exposed depend on that frequency table. And this cpufreq driver doesn't expose that freq table... And so this patch is dropped :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/